Skip to content

Commit

Permalink
ci: fix broken website link check (#658)
Browse files Browse the repository at this point in the history
It was broken since
6109acd
Signed-off-by: spacewander <[email protected]>
  • Loading branch information
spacewander authored Jul 29, 2024
1 parent 35d34aa commit d891f67
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
with:
# ./tmp is cached for htmltest
path: |
./site/bin
./site/tmp
key: ${{ runner.os }}-${{ hashFiles('./Makefile') }}

Expand Down
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,4 @@ external/*
e2e/log
.idea
# helm charts
manifests/charts/**/*.tgz
.idea
manifests/charts/**/*.tgz
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,9 @@ fix-cjk: dev-tools
.PHONY: lint-website
lint-website: $(LOCALBIN)
test -x $(LOCALBIN)/htmltest || GOBIN=$(LOCALBIN) go install github.com/wjdp/[email protected]
$(LOCALBIN)/htmltest --conf ./.htmltest.yml ./public | grep -E '(target does not exist|Non-OK status: 404)' \
&& exit 1 || true
cd ./site && $(LOCALBIN)/htmltest --conf ./.htmltest.yml ./public > /tmp/htmltest.log || true
@# ignore 'lookup htnn.mosn.io: no such host' error for now
test -f /tmp/htmltest.log && (grep -E '(target does not exist|Non-OK status: 404)' /tmp/htmltest.log && exit 1 || true)

.PHONY: lint-remain
lint-remain:
Expand Down

0 comments on commit d891f67

Please sign in to comment.