Add Rails 8 compatibility and fix underscore handling #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generator was incorrectly preventing rename operations when the new folder name matched the current folder name. This change allows the rename to proceed by checking if the new path is different from the current Rails root path before throwing an error.
- Fix app name detection for Rails' underscore patterns (e.g., rails_8_template vs rails8_template) by reading database.yml - Add support for Rails 8 files: Kamal deploy.yml, PWA manifest, Dockerfile, and multi-database configurations - Add safe_replace_into_file() for optional file handling - Update file search patterns to include .yml and .json.erb - Handle humanized app names in layout titles - Update README with Rails 8.0.2 and Ruby 3.4.5 compatibility The name detection fix addresses the case where a module name like `Rails8Template` can map to either `rails8_template` or `rails_8_template`. The name in `database.yml` is more reliable.
raghubetina
force-pushed
the
rails-8-compatibility
branch
from
e77577c to
c95f399
Compare
When renaming apps with hyphens (e.g., "api-proxy"), the gem now properly handles the conversion to underscores in database names. Uses ActiveSupport's parameterize method to normalize directory names and checks both the original detected name and the normalized directory name when replacing in config files. - Added @old_app_name_from_dir to track normalized directory name - Database replacements now check both variants when they differ - Also applies to cable.yml, deploy.yml, and production.rb configs - Added comprehensive tests for hyphen handling scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for the library. I've been using it with the updates included in this PR, and thought I would share them back in case they're useful for you too.
The name detection fix addresses the case where a module name like
Rails8Templatecan map to eitherrails8_templateorrails_8_template. The name indatabase.ymlis more reliable.