Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use precompile contracts correctly #181

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

ryanmorphl2
Copy link
Contributor

@ryanmorphl2 ryanmorphl2 commented Mar 13, 2025

1. Purpose or design rationale of this PR

fix bug, use precompile contracts correctly

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • New Features
    • Added support for the new Morph203 chain protocol, which enables optimized handling of relevant transactions while maintaining the consistency of existing chain rules.

@ryanmorphl2 ryanmorphl2 requested a review from a team as a code owner March 13, 2025 13:55
@ryanmorphl2 ryanmorphl2 requested review from r3aker86 and removed request for a team March 13, 2025 13:55
Copy link

coderabbitai bot commented Mar 13, 2025

Walkthrough

This change adds a new case to the precompile method in the EVM struct to handle the Morph203 chain rules. When evm.chainRules.IsMorph203 is true, the method assigns the set of precompiled contracts to PrecompiledContractsMorph203. The existing cases for other chain rules (Bernoulli, Archimedes, Berlin, Istanbul, and Byzantium) remain unchanged.

Changes

File Summary
core/vm/evm.go Adds a new condition in the precompile method to handle Morph203 chain rules by setting precompiled contracts accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant EVM
    participant ChainRules

    Client->>EVM: Invoke precompile method
    EVM->>ChainRules: Check if IsMorph203 is true
    alt IsMorph203 true
        EVM->>EVM: Set precompiled contracts to PrecompiledContractsMorph203
    else Other chain rules
        EVM->>EVM: Process with existing precompiled contracts
    end
Loading

Possibly related PRs

Suggested reviewers

  • SecurityLife
  • FletcherMan
  • curryxbo

Poem

I'm a rabbit with a coding hop,
Morph203 steps in with a brand new bop.
A precompile tweak to set things right,
Jumping through cases from morning till night.
Enjoy the changes with a joyful trot! 🐇

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b13a50 and 4b3f7f1.

📒 Files selected for processing (1)
  • core/vm/evm.go (1 hunks)
🔇 Additional comments (1)
core/vm/evm.go (1)

49-50:

✅ Verification successful

Addition of Morph203 chain rules check looks good.

This change correctly adds support for Morph203 chain rules by adding a new case to the precompile method's switch statement. The code follows the existing pattern used for other chain rules (Bernoulli, Archimedes, etc.) and properly assigns the corresponding precompiled contracts map.

The placement at the top of the switch statement means Morph203 takes precedence over other chain rules, which is likely intentional based on the PR title "fix: use precompile contracts correctly".


🏁 Script executed:

#!/bin/bash
# Check if PrecompiledContractsMorph203 is properly defined elsewhere in the codebase
rg -A 3 "PrecompiledContractsMorph203" --type go

Length of output: 961


Morph203 Chain Rules Check Verified

The addition of the Morph203 chain rules case in core/vm/evm.go has been verified. The PrecompiledContractsMorph203 variable is properly defined in core/vm/contracts.go and follows the established pattern alongside other chain rules (e.g., Bernoulli, Archimedes). The new case correctly assigns the Morph203 precompile contracts, ensuring that Morph203 rules take precedence as intended.

  • Verified existence and assignment of PrecompiledContractsMorph203 in both core/vm/evm.go and core/vm/contracts.go.
  • Pattern usage in the switch case aligns with existing cases for other chain rules.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ryanmorphl2 ryanmorphl2 requested review from FletcherMan, curryxbo and a team March 13, 2025 13:56
@ryanmorphl2 ryanmorphl2 merged commit 030082c into main Mar 13, 2025
1 check passed
@ryanmorphl2 ryanmorphl2 deleted the ryan/fix-precompile branch March 13, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants