Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracer): add withLog to callTracer #176

Open
wants to merge 1 commit into
base: release/2.0.x
Choose a base branch
from

Conversation

ryanmorphl2
Copy link
Contributor

feat(tracer): add withLog to callTracer

1. Purpose or design rationale of this PR

This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. The config object is passed in JSON encoding (from Go json.RawMessage) to be decoded by the tracer itself.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

feat(tracer): add withLog to callTracer
@ryanmorphl2 ryanmorphl2 requested a review from a team as a code owner January 21, 2025 09:23
@ryanmorphl2 ryanmorphl2 requested a review from yunxu1 January 21, 2025 09:23
@FletcherMan FletcherMan changed the title Merge pull request #175 from morph-l2/ryan/tracer-with-logs feat(tracer): add withLog to callTracer Jan 21, 2025
Copy link

@twcctop twcctop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants