Skip to content

fix(cli): route JavaScript applications from analyze#402

Merged
N0zoM1z0 merged 1 commit into
mainfrom
fix/cli-javascript-analysis-routing
Jul 21, 2026
Merged

fix(cli): route JavaScript applications from analyze#402
N0zoM1z0 merged 1 commit into
mainfrom
fix/cli-javascript-analysis-routing

Conversation

@N0zoM1z0

Copy link
Copy Markdown
Collaborator

Summary

  • route generic rea analyze calls for directories and .asar paths to the static JavaScript application provider
  • keep native files, .app bundles, and explicit --provider / --snapshot requests on the existing deep-analysis path
  • share the JavaScript CLI execution boundary and return actionable approval validation details
  • document the generic route and verify it in source and packaged CLI tests

Root cause

The generic analyze command was hard-wired to binary_overview, so JavaScript application directories and ASARs reached native deep-provider discovery even though REA already exposed a static JavaScript application service and dedicated CLI command.

Behavior change

rea analyze PATH --approved now detects directories and .asar files and invokes analyze_javascript_application when no provider or snapshot override is present. The request still requires an administrator-approved investigation root and per-call approval.

Verification

  • npm run check — 343 test files, 2,296 tests passed
  • focused Electron/application CLI tests — 13 tests passed
  • isolated package, install, discovery, dedicated JS CLI, and generic JS routing verification passed
  • git diff --check

The complete npm run verify:package reached and passed the artifact/JavaScript routing stage, then the existing interactive setup PTY produced no output and hit its 20-second timeout in this environment. The relevant packaged stages were rerun independently and passed.

Real Hopper verification: not performed (provider adapter unchanged).
Real Ghidra verification: not performed (provider adapter unchanged).

Copy link
Copy Markdown
Collaborator Author

LGTM!

@N0zoM1z0
N0zoM1z0 merged commit 737940c into main Jul 21, 2026
12 checks passed
@N0zoM1z0
N0zoM1z0 deleted the fix/cli-javascript-analysis-routing branch July 21, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant