fix(cli): route JavaScript applications from analyze#402
Merged
Conversation
Collaborator
Author
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rea analyzecalls for directories and.asarpaths to the static JavaScript application provider.appbundles, and explicit--provider/--snapshotrequests on the existing deep-analysis pathRoot cause
The generic
analyzecommand was hard-wired tobinary_overview, so JavaScript application directories and ASARs reached native deep-provider discovery even though REA already exposed a static JavaScript application service and dedicated CLI command.Behavior change
rea analyze PATH --approvednow detects directories and.asarfiles and invokesanalyze_javascript_applicationwhen no provider or snapshot override is present. The request still requires an administrator-approved investigation root and per-call approval.Verification
npm run check— 343 test files, 2,296 tests passedgit diff --checkThe complete
npm run verify:packagereached and passed the artifact/JavaScript routing stage, then the existing interactive setup PTY produced no output and hit its 20-second timeout in this environment. The relevant packaged stages were rerun independently and passed.Real Hopper verification: not performed (provider adapter unchanged).
Real Ghidra verification: not performed (provider adapter unchanged).