Skip to content

[Fix] Harden validation, configuration, and adapter boundaries - #133

Merged
morluto merged 5 commits into
mainfrom
codex/fix-issues-124-132
Jul 23, 2026
Merged

[Fix] Harden validation, configuration, and adapter boundaries#133
morluto merged 5 commits into
mainfrom
codex/fix-issues-124-132

Conversation

@morluto

@morluto morluto commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

This PR fixes the validation, configuration-inspection, lifecycle, and adapter-boundary defects tracked in #124#132.

  • Treats expected MCP process termination during protocol shutdown as non-fatal after a successful protocol run, while preserving real run and shutdown errors.
  • Makes nil environment handling consistent across execution runners; an empty validation allowlist now inherits the process environment.
  • Rejects malformed Claude MCP registrations, non-string Claude arguments, and malformed code-index exclusion globs.
  • Guards optional nested GitHub models explicitly during conversion.
  • Ensures CLI error returns run deferred Service.Close cleanup.
  • Removes confirmed-unused MCP handlers and helpers.
  • Stabilizes the process-tree telemetry regression test by giving the child process a deterministic observation window.

Review order

  1. 2ed471d — behavioral fixes and regression coverage.
  2. 86a149f — confirmed dead-code removal.

Validation

  • go test ./...
  • go test -race ./internal/evidence -run 'TestMCPStdioRunnerRecordsSDKMilestones|TestExpectedMCPShutdownSignalIsNonFatal|TestExecRunnerCapturesProcessTreeTelemetryAndCleanup' -count=1
  • make verify

Fixes #124
Fixes #125
Fixes #126
Fixes #127
Fixes #128
Fixes #129
Fixes #130
Fixes #131
Fixes #132

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@morluto
morluto merged commit e4f1b44 into main Jul 23, 2026
13 checks passed
@morluto
morluto deleted the codex/fix-issues-124-132 branch July 28, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment