[Fix] Harden validation, configuration, and adapter boundaries - #133
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the validation, configuration-inspection, lifecycle, and adapter-boundary defects tracked in #124–#132.
Service.Closecleanup.Review order
2ed471d— behavioral fixes and regression coverage.86a149f— confirmed dead-code removal.Validation
go test ./...go test -race ./internal/evidence -run 'TestMCPStdioRunnerRecordsSDKMilestones|TestExpectedMCPShutdownSignalIsNonFatal|TestExecRunnerCapturesProcessTreeTelemetryAndCleanup' -count=1make verifyFixes #124
Fixes #125
Fixes #126
Fixes #127
Fixes #128
Fixes #129
Fixes #130
Fixes #131
Fixes #132