fix(mcp): accept exact thread sync selectors - #119
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The MCP contract documents exact thread synchronization with
selection: "threads", but schema defaults and application validation treated omitted repository-only fields as if the caller had supplied them. Valid exact selectors were rejected before the sync job ran.This moves mode-specific defaults to runtime, rejects repository filters only when they are actually present, and validates every exact thread reference before job submission. Repository grouping still shares bounded GitHub requests, while the durable result expands back to one ordered outcome per requested thread. Repeated identical observations no longer add duplicate history rows.
The stdio regression sends the documented selector through the real MCP transport and proves one exact thread is synchronized without a broad list read.
Closes #112.
Testing
make verifyCompatibility and scope
Repository-selection defaults remain unchanged. Exact-thread mode performs bounded GitHub reads only after explicit tool invocation; no GitHub mutation path is added.