chore(ci): remove redundant test work#109
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant CI work and shorten isolated repository tests using Go's built-in scheduler.
PR #108 made cached tests the default local loop and separated expensive validation. Profiling its green CI run showed that the complete Go suite still ran twice on Linux: once as a plain matrix job and once with coverage. The plain Linux job took 81 seconds but did not exercise a distinct platform or mode. Profiling local tests also showed independent temp-repository fixtures running serially in the two slowest relevant packages.
This follow-up:
unsupportedlanguage name and reusesmake testat pre-push;internal/workspacein focused race validation now that its fixtures execute concurrently.Coverage, focused race detection, cross-platform tests, generated-output checks, linting, and security analysis remain required.
Suggested review order
.github/workflows/ci.yml,.pre-commit-config.yaml, andMakefile.internal/workspace/workspace_test.go.Testing
make verify(45.94 seconds)make test-uncached(30.43 seconds)make cover-check(72.9%, 41.20 seconds)make test-race(app, corpus, and workspace)pre-commit run --all-filespre-commit validate-config .pre-commit-config.yamlactionlint .github/workflows/ci.ymlPerformance evidence
internal/workspacefell from 5.16 seconds to about 1.29 seconds per run across ten repetitions (75%).Compatibility and scope
No product code, public behavior, dependencies, coverage threshold, or platform coverage changes are included. Tests that mutate process environment remain serial.