-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tego build #1
Open
morganava
wants to merge
107
commits into
blueprint-master
Choose a base branch
from
tego-build
base: blueprint-master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tego build #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.x.x is already in use by ricochet legacy. Version 2.x.x should be left in case legacy is updated (+major revision no corresponds to tor version) Ricochet refresh should instead use version 3.x.x
QStandardPaths::DataLocation is deprecated, QStandardPaths::AppDataLocation should be used instead
CFBundleSignature does not need to be updated as versions of macOS >10.7 ignore this field
As of C++11, implicit declarations of operators are deprecated. Previous to this, implicit declarations of operators would function the same as: Class& operator<op>(const Class&) = default; Explicitly declaring an operator as above will avoid this warning and maintain compatability with future C++ standards
…-ignore Add ricochet-refresh to the gitignore
…fier Update ricochet refresh to have a new CFBundleIdentifier
If they pass the RFC4648 test vectors they should work with anything else, no need to have extra tests
Fix implicit operator declaration warning
Base32 tests + make base32 code RFC4648 compliant
Scaling to higher DPI + updated .gitignore for new file tree
…yntax and other warnings
- moved pri file sinto qmake_includes directory - created artifacts.pri which outputs binaries and artifacts into /builds/(debug|release)/$${TARGET} directories - created compiler_flags.pri for setting shared compiler flags - created libtego static library with logging functionality - libtego to contain ed25519 functionality and links into ricochet-refresh - create libtego_ui static library which contains all of ricochet-refresh's cpp sources - libtego_ui linked into tego_ui and tests for faster builds - all projects now use precompiled headers to speed up build times - non-linux building almost certainly broken
…ed25519 functions - integrates minimal amount of tor maint-0.4.4 code needed for ed25519 crypto and base32 and base64 encoding/decoding - libtego exposes the ed25519 types and functions required for v2 -> v3 conversion - implemented using the 'hourglass' pattern: C++ with exception handling internal to libtego, which are caught at the C ABI and converted to out tego_error_t params. The C ABI can be called from C (or most anything else) and errors handled without worrying about C++ exceptions. For C++ callers, a helper class tego::throw_on_error is provided which converts the tego_error_t messages back to C++ exceptions - also implements a couple of helper functions in tego/utilties.hpp
- removed legacy v2 rleated code - replaced with v3 ed25519 code implemented in libtego - much of CryptoKey implementation is just a passthrough to ed25519 function in libtego - removed base32 implementation from CryptoKey; all ed25519 related base32 and base64 is now encapsulated in libtego - updatd tst_cryptokey tests - added link time code generation to all projects in debug so the linker does not complain about missing functions in ed25519 source that are not actually used - private key now saved in settings json in ED25519-V3 tor KeyBlob format - tweaked hidden service authorization proof message to send the client's service id (which contains the public key) rather than just the public key
Updated README.md in prep for public access to the repo to warn about work in progress status.
V3onion review
Debian packaging, manpage, fixed static build
…enerate64() tego_ui: updated deprecated qsrand to QRandomGenerator::global()->seed()
QRandomGenerator::global is already seeded by QT, and attempting to seed it manually causes a crash. See https://doc.qt.io/qt-5/qrandomgenerator.html#global
Qt fixes + protobuf fixes
…-build - explicitly setting the openssl and protobuf roots now required - rolled back some 'auto' usage in cpp sources to fix build breaks - added tor_fix_source_file stub for windows build - added common include for linker options - updated compiler and linker flags includes to support building on all our platforms - stubbed out tests for macx builds to fix build break - removed buildscripts directory
…setApplicationVesion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed to build ricochet-refresh from my tego-build project: