chore(ci): drop secrets: inherit from PR verify#11
Open
apokusin wants to merge 1 commit into
Open
Conversation
The verify workflow does not reference any secrets, but inheriting them exposed NPM_TOKEN and GPG_PRIVATE_KEY to PR builds from same-repo branches — an unnecessary attack surface highlighted by the TanStack npm supply-chain compromise (poisoned PR build exfiltrating release tokens). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
moonwell-ai | cec5076 | May 12 2026, 04:54 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
moonwell-api | cec5076 | May 12 2026, 04:54 PM |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify.ymlwithsecrets: inherit, exposingNPM_TOKENandGPG_PRIVATE_KEYto same-repo branch PRs even thoughverify.ymlnever references them.changesets.yml) is unaffected — it sets its ownsecrets.NPM_TOKEN/secrets.GPG_PRIVATE_KEYexplicitly and runs only onpush: main.Test plan
Verify) still passes on this PR — i.e. nothing in verify actually needed the inherited secrets.🤖 Generated with Claude Code