MSP-72 Converted to dns-canary to helm chart#29
Merged
jeff-french merged 5 commits intomainfrom Mar 14, 2025
Merged
Conversation
Contributor
Author
|
I reviewed this error with AI. Seems like the error is related to versioning with the main file and since this is a new addition, the linter is getting caught trying to compare versions. It spit out a draft fix for the github actions to more gracefully handle new chart additions: # name: lint-test
on:
pull_request:
paths:
- 'charts/**'
jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4
with:
fetch-depth: 0 # Make sure we have history to check against `main`
- name: Set Chart Name
run: |
CHANGED_CHART=$(ls charts | grep dns-canary || true)
if [ -z "$CHANGED_CHART" ]; then
echo "❌ No changes detected for dns-canary, this job may have been triggered incorrectly."
exit 1
fi
echo "CHART_NAME=$CHANGED_CHART" >> $GITHUB_ENV
- name: Detect if Chart is New
run: |
if git ls-tree -r origin/main --name-only | grep -q "charts/$CHART_NAME/Chart.yaml"; then
echo "NEW_CHART=false" >> $GITHUB_ENV
else
echo "NEW_CHART=true" >> $GITHUB_ENV
fi
- name: Log Detection Result
run: |
echo "Is this a new chart? $NEW_CHART"
- name: Helm Setup
uses: azure/setup-helm@v4
with:
version: v3.12.0
- name: Helm Lint (New Chart Flow)
if: env.NEW_CHART == 'true'
run: |
echo "🔔 Detected new chart ($CHART_NAME). Skipping version bump check."
helm lint charts/$CHART_NAME/
- name: Helm Lint (Existing Chart Flow)
if: env.NEW_CHART == 'false'
run: |
echo "🔔 Existing chart detected. Performing normal lint + version bump check."
# Example - customize this part if your repo has special rules for version bumps
helm lint charts/$CHART_NAME/
# Optional - Add version comparison logic if needed for existing charts.``` |
58b2b93 to
2784d07
Compare
Contributor
Author
|
Linting is failing, but I'm not sure how to troubleshoot. |
jeff-french
requested changes
Mar 11, 2025
Contributor
jeff-french
left a comment
There was a problem hiding this comment.
Need to rename the directory to dns-canary so that it's a valid DNS name when used to create k8s resources.
jeff-french
requested changes
Mar 13, 2025
Contributor
jeff-french
left a comment
There was a problem hiding this comment.
Just a couple more small changes. Once we have this published, let's deploy it into the Moonswitch cluster for testing first.
jeff-french
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.