DynValue ToString uses InvariantCulture#327
Open
KiwifruitDev wants to merge 1 commit intomoonsharp-devs:legacy/2.0from
Open
DynValue ToString uses InvariantCulture#327KiwifruitDev wants to merge 1 commit intomoonsharp-devs:legacy/2.0from
KiwifruitDev wants to merge 1 commit intomoonsharp-devs:legacy/2.0from
Conversation
Performing this change allows decimal values to concatenate through strings correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performing this change allows decimal values to concatenate through strings correctly.
When a user's Windows regional format uses
,for decimal separation, MoonSharp does not handle it in this instance.For my purposes, I have a software that uses MoonSharp for FFmpeg operations.
This is a snippet from a Lua script that does not execute correctly:
The values
startandmultipliermay not output in a valid format, resulting in this error:After these changes were made, the issue no longer occurs.
This may be considered a duplicate or continuation of #295.