fix: Remove --title arg from node.

moonrepo · Jun 5, 2023 · b5c36b3 · b5c36b3
1 parent 5141d9b
commit b5c36b3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/crates/cli/tests/snapshots/run_node_test__passes_args_to_the_node_bin.snap b/crates/cli/tests/snapshots/run_node_test__passes_args_to_the_node_bin.snap
@@ -1,11 +1,10 @@
 ---
 source: crates/cli/tests/run_node_test.rs
-assertion_line: 194
-expression: "get_path_safe_output(&assert, fixture.path())"
+expression: assert.output()
 ---
 ▪▪▪▪ npm install
 ▪▪▪▪ node:binExecArgs
-[ '--title', 'node:binExecArgs', '--preserve-symlinks' ]
+[ '--preserve-symlinks' ]
 ▪▪▪▪ node:binExecArgs (100ms)
 
 Tasks: 1 completed

diff --git a/crates/node/platform/src/actions/run_target.rs b/crates/node/platform/src/actions/run_target.rs
@@ -27,8 +27,8 @@ fn create_node_options(
 ) -> Result<Vec<String>, MoonError> {
     let mut options = string_vec![
         // "--inspect", // Enable node inspector
-        "--title",
-        &task.target.id,
+        // "--title",
+        // &task.target.id,
     ];
 
     options.extend(node_config.bin_exec_args.to_owned());

diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 #### 🐞 Fixes
 
+- Node.js
+  - Fixed an issue where some workers/packages would fail while inheriting parent args.
 - Rust
   - Fixed an issue where `cargo generate-lockfile` would run in the wrong directory.
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,8 @@ @@
     #### 🐞 Fixes
+    - Node.js
+      - Fixed an issue where some workers/packages would fail while inheriting parent args.
     - Rust
       - Fixed an issue where `cargo generate-lockfile` would run in the wrong directory.
@@ Expand Down @@