Skip to content

Conversation

o2gy84
Copy link

@o2gy84 o2gy84 commented Feb 28, 2024

It is confused when fencing just works if setting is actually etcd.fencing_enabled: false.

@ochaton
Copy link
Member

ochaton commented Mar 20, 2024

thx! fun staff, is that etcd.fencing_enabled can be boolean true or string "true". In ETCD every key/value is a string. Configuring etcd.boolean_auto enforces moonlibs/config to guess whether the string "true" is actually a boolean true.

To complete your fix, could you change your fix to this:

tostring(config.get('etcd.fencing_enabled')) == 'true'

this should solve every possible way of moonlibs/config boolean-guessing setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants