Skip to content

MOBILE-4802 core-iframe: Add allow attribute to iframe #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

MOBILE-4802 core-iframe: Add allow attribute to iframe #4505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/components/iframe/core-iframe.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
<!-- allowfullscreen cannot be set dynamically using attribute binding, define 2 iframe elements. -->
@if (allowFullscreen) {
<iframe #iframe class="core-iframe" [attr.id]="id" [ngStyle]="{'width': iframeWidth, 'height': iframeHeight}" [src]="safeUrl"
allowfullscreen="true" [class.core-iframe-loading]="loading">
allowfullscreen="true" [class.core-iframe-loading]="loading" [allow]="allow">
</iframe>
} @else {
<iframe #iframe class="core-iframe" [attr.id]="id" [ngStyle]="{'width': iframeWidth, 'height': iframeHeight}" [src]="safeUrl"
[class.core-iframe-loading]="loading">
[class.core-iframe-loading]="loading" [allow]="allow">
</iframe>
}

Expand Down
2 changes: 2 additions & 0 deletions src/core/components/iframe/iframe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
SimpleChange,
OnDestroy,
inject,
input,
} from '@angular/core';
import { SafeResourceUrl } from '@angular/platform-browser';

Expand Down Expand Up @@ -70,6 +71,7 @@ export class CoreIframeComponent implements OnChanges, OnDestroy {
this.initIframeElement();
}

readonly allow = input<string>();
@Input() src?: string;
@Input() id: string | null = null;
@Input() iframeWidth = '100%';
Expand Down
Loading