MOBILE-4842 behat: Add constants to behat blocking service

Author: crazyserver

src/testing/services/behat-blocking.ts

@@ -27,6 +27,16 @@ import {
 import { filter } from 'rxjs';
 import { CoreNavigator } from '@services/navigator';
 
+enum BehatBlocking {
+    DOM_MUTATION = 'dom-mutation',
+    BLOCKED = 'blocked',
+    FORCED_DELAY = 'forced-delay',
+    DELAY = 'DELAY', // Special entry to indicate there are pending entries.
+    HTTP_REQUEST = 'httprequest-', // Prefix for HTTP requests.
+    GENERATED = 'generated-', // Prefix for generated keys.
+    NAVIGATION = 'navigation-', // Prefix for navigation keys.
+}
+
 /**
  * Behat block JS manager.
  */
@@ -136,10 +146,10 @@ export class TestingBehatBlockingService {
     block(key = ''): string {
         // Add a special DELAY entry whenever another entry is added.
         if (this.pendingList.length === 0) {
-            this.pendingList.push('DELAY');
+            this.pendingList.push(BehatBlocking.DELAY);
         }
         if (!key) {
-            key = `generated-${this.keyIndex}`;
+            key = `${BehatBlocking.GENERATED}${this.keyIndex}`;
             this.keyIndex++;
         }
         this.pendingList.push(key);
@@ -187,7 +197,7 @@ export class TestingBehatBlockingService {
      * Adds a pending key to the array, but removes it after some ticks.
      */
     async delay(): Promise<void> {
-        const key = this.block('forced-delay');
+        const key = this.block(BehatBlocking.FORCED_DELAY);
         await this.unblock(key);
     }
 
@@ -218,7 +228,7 @@ export class TestingBehatBlockingService {
 
             if (!this.recentMutation) {
                 this.recentMutation = true;
-                this.block('dom-mutation');
+                this.block(BehatBlocking.DOM_MUTATION);
 
                 setTimeout(() => {
                     this.pollRecentMutation();
@@ -246,7 +256,7 @@ export class TestingBehatBlockingService {
     protected pollRecentMutation(): void {
         if (Date.now() - this.lastMutation > 500) {
             this.recentMutation = false;
-            this.unblock('dom-mutation');
+            this.unblock(BehatBlocking.DOM_MUTATION);
 
             return;
         }
@@ -285,12 +295,12 @@ export class TestingBehatBlockingService {
 
         if (isBlocked) {
             if (!this.waitingBlocked) {
-                this.block('blocked');
+                this.block(BehatBlocking.BLOCKED);
                 this.waitingBlocked = true;
             }
         } else {
             if (this.waitingBlocked) {
-                this.unblock('blocked');
+                this.unblock(BehatBlocking.BLOCKED);
                 this.waitingBlocked = false;
             }
         }
@@ -306,7 +316,7 @@ export class TestingBehatBlockingService {
         XMLHttpRequest.prototype.open = function(...args) {
             NgZone.run(() => {
                 const index = requestIndex++;
-                const key = `httprequest-${index}`;
+                const key = `${BehatBlocking.HTTP_REQUEST}${index}`;
                 const isAsync = args[2] !== false;
 
                 try {