MOBILE-4842 resource: Small improvements found when debugging behat

Author: crazyserver

src/addons/mod/resource/components/index/index.ts

@@ -192,7 +192,6 @@ export class AddonModResourceIndexComponent extends CoreCourseModuleMainResource
      * Opens a file.
      *
      * @param iOSOpenFileAction Action to do in iOS.
-     * @returns Promise resolved when done.
      */
     async open(iOSOpenFileAction?: OpenFileAction): Promise<void> {
         let downloadable = await CoreCourseModulePrefetchDelegate.isModuleDownloadable(this.module, this.courseId);
@@ -212,12 +211,14 @@ export class AddonModResourceIndexComponent extends CoreCourseModuleMainResource
                     await alert.onWillDismiss();
                 }
 
-                return AddonModResourceHelper.openModuleFile(this.module, this.courseId, { iOSOpenFileAction });
+                await AddonModResourceHelper.openModuleFile(this.module, this.courseId, { iOSOpenFileAction });
+
+                return;
             }
         }
 
         // The resource cannot be downloaded, open the activity in browser.
-        await CoreSites.getCurrentSite()?.openInBrowserWithAutoLogin(this.module.url || '');
+        await CoreSites.getRequiredCurrentSite().openInBrowserWithAutoLogin(this.module.url ?? '');
     }
 
 }

src/addons/mod/resource/services/resource-helper.ts

@@ -183,7 +183,6 @@ export class AddonModResourceHelperProvider {
      * @param module Module where to get the contents.
      * @param courseId Course Id, used for completion purposes.
      * @param options Options to open the file.
-     * @returns Resolved when done.
      */
     async openModuleFile(module: CoreCourseModuleData, courseId: number, options: CoreOpenerOpenFileOptions = {}): Promise<void> {
         const modal = await CoreLoadings.show();