MOBILE-4842 chore: Standarize signal getters

crazyserver · crazyserver · commit 6348e9316d68 · 2025-09-25T17:30:18.000+02:00
diff --git a/src/addons/blog/pages/index/index.ts b/src/addons/blog/pages/index/index.ts
@@ -90,7 +90,7 @@ export default class AddonBlogIndexPage implements OnInit, OnDestroy {
     syncObserver: CoreEventObserver;
     optionsAvailable = false;
     readonly hasOfflineDataToSync = signal(false);
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     siteId: string;
     syncIcon = CoreConstants.ICON_SYNC;
     readonly syncHidden = computed(() => !this.loaded() || !this.isOnline() || !this.hasOfflineDataToSync());
diff --git a/src/addons/calendar/pages/day/day.ts b/src/addons/calendar/pages/day/day.ts
@@ -85,7 +85,7 @@ export default class AddonCalendarDayPage implements OnInit, OnDestroy {
     periodName?: string;
     manager?: CoreSwipeSlidesDynamicItemsManager<PreloadedDay, AddonCalendarDaySlidesItemsManagerSource>;
     loaded = false;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     syncIcon = CoreConstants.ICON_LOADING;
     filter: AddonCalendarFilter = {
         filtered: false,
diff --git a/src/addons/calendar/pages/event/event.ts b/src/addons/calendar/pages/event/event.ts
@@ -96,7 +96,7 @@ export default class AddonCalendarEventPage implements OnInit, OnDestroy {
     reminders: AddonCalendarEventReminder[] = [];
     canEdit = false;
     hasOffline = false;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     syncIcon = CoreConstants.ICON_LOADING; // Sync icon.
     canScheduleExactAlarms = true;
     scheduleExactWarningHidden = false;
diff --git a/src/addons/calendar/pages/index/index.ts b/src/addons/calendar/pages/index/index.ts
@@ -81,7 +81,7 @@ export default class AddonCalendarIndexPage implements OnInit, OnDestroy {
     courses: CoreEnrolledCourseData[] = [];
     loaded = false;
     hasOffline = false;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     syncIcon = CoreConstants.ICON_LOADING;
     showCalendar = true;
     loadUpcoming = false;
diff --git a/src/addons/mod/chat/components/users-modal/users-modal.ts b/src/addons/mod/chat/components/users-modal/users-modal.ts
@@ -37,7 +37,7 @@ export class AddonModChatUsersModalComponent implements OnInit {
     users: AddonModChatUser[] = [];
     usersLoaded = false;
     currentUserId: number;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
 
     constructor() {
         this.currentUserId = CoreSites.getCurrentSiteUserId();
diff --git a/src/addons/mod/chat/pages/chat/chat.ts b/src/addons/mod/chat/pages/chat/chat.ts
@@ -57,7 +57,7 @@ export default class AddonModChatChatPage implements OnInit, OnDestroy, CanLeave
     messages: AddonModChatFormattedMessage[] = [];
     newMessage?: string;
     polling?: number;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     currentUserId: number;
     sending = false;
     courseId!: number;
diff --git a/src/addons/mod/feedback/pages/form/form.ts b/src/addons/mod/feedback/pages/form/form.ts
@@ -80,7 +80,7 @@ export default class AddonModFeedbackFormPage implements OnInit, CanLeave {
     component = ADDON_MOD_FEEDBACK_COMPONENT_LEGACY;
     readonly offline = linkedSignal(() => !this.isOnline());
 
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     feedbackLoaded = false;
     access?: AddonModFeedbackGetFeedbackAccessInformationWSResponse;
     items: AddonModFeedbackFormItem[] = [];
diff --git a/src/addons/mod/forum/pages/discussion/discussion.ts b/src/addons/mod/forum/pages/discussion/discussion.ts
@@ -101,7 +101,7 @@ export default class AddonModForumDiscussionPage implements OnInit, AfterViewIni
     posts: Post[] = [];
     discussionLoaded = false;
     postSubjects!: { [id: string]: string };
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     postHasOffline!: boolean;
     sort: SortType = 'nested';
     trackPosts!: boolean;
diff --git a/src/addons/mod/h5pactivity/components/index/index.ts b/src/addons/mod/h5pactivity/components/index/index.ts
@@ -104,7 +104,7 @@ export class AddonModH5PActivityIndexComponent extends CoreCourseModuleMainActiv
     hasMissingDependencies = false;
     saveFreq?: number;
     contentState?: string;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     triedToPlay = false;
 
     protected fetchContentDefaultError = 'addon.mod_h5pactivity.errorgetactivity';
diff --git a/src/addons/mod/resource/components/index/index.ts b/src/addons/mod/resource/components/index/index.ts
@@ -63,7 +63,7 @@ export class AddonModResourceIndexComponent extends CoreCourseModuleMainResource
     warning = '';
     isIOS = false;
     openFileAction = OpenFileAction;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     isStreamedFile = false;
     shouldOpenInBrowser = false;
 
diff --git a/src/addons/mod/scorm/components/index/index.ts b/src/addons/mod/scorm/components/index/index.ts
@@ -103,7 +103,7 @@ export class AddonModScormIndexComponent extends CoreCourseModuleMainActivityCom
     onlineAttempts: AttemptGrade[] = []; // Grades for online attempts.
     offlineAttempts: AttemptGrade[] = []; // Grades for offline attempts.
     gradesExpanded = false;
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
 
     protected fetchContentDefaultError = 'addon.mod_scorm.errorgetscorm'; // Default error to show when loading contents.
     protected syncEventName = ADDON_MOD_SCORM_DATA_AUTO_SYNCED;
diff --git a/src/addons/mod/wiki/components/index/index.ts b/src/addons/mod/wiki/components/index/index.ts
@@ -91,7 +91,7 @@ export class AddonModWikiIndexComponent extends CoreCourseModuleMainActivityComp
     pluginName = 'wiki';
     groupWiki = false;
 
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
 
     wiki?: AddonModWikiWiki; // The wiki instance.
     isMainPage = false; // Whether the user is viewing wiki's main page (just entered the wiki).
diff --git a/src/core/features/comments/pages/viewer/viewer.ts b/src/core/features/comments/pages/viewer/viewer.ts
@@ -88,7 +88,7 @@ export default class CoreCommentsViewerPage implements OnInit, OnDestroy, AfterV
     currentUserId: number;
     sending = false;
     newComment = '';
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
 
     protected addDeleteCommentsAvailable = false;
     protected syncObserver?: CoreEventObserver;
diff --git a/src/core/features/course/components/module-summary/module-summary.ts b/src/core/features/course/components/module-summary/module-summary.ts
@@ -74,7 +74,7 @@ export class CoreCourseModuleSummaryComponent implements OnInit, OnDestroy {
     downloadTimeReadable = ''; // Last download time in a readable format.
     grades?: CoreGradesFormattedTableRow[];
     blog = false; // If blog is available.
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly isOnline = CoreNetwork.onlineSignal;
     course?: CoreCourseAnyCourseData;
     modicon = '';
     moduleNameTranslated = '';
diff --git a/src/core/features/settings/pages/deviceinfo/deviceinfo.ts b/src/core/features/settings/pages/deviceinfo/deviceinfo.ts
@@ -95,8 +95,8 @@ export default class CoreSettingsDeviceInfoPage {
             versionCode: CoreConstants.CONFIG.versioncode,
             compilationTime: CoreConstants.BUILD.compilationTime || 0,
             lastCommit: CoreConstants.BUILD.lastCommitHash || '',
-            isOnline: CoreNetwork.onlineSignal(),
-            wifiConnection: computed(() => CoreNetwork.connectionTypeSignal()() === CoreNetworkConnectionType.WIFI),
+            isOnline: CoreNetwork.onlineSignal,
+            wifiConnection: computed(() => CoreNetwork.connectionTypeSignal() === CoreNetworkConnectionType.WIFI),
             localNotifAvailable: CoreLocalNotifications.isPluginAvailable() ? 'yes' : 'no',
             pushId: CorePushNotifications.getPushId(),
             deviceType: '',
diff --git a/src/core/features/settings/pages/site/site.ts b/src/core/features/settings/pages/site/site.ts
@@ -48,8 +48,8 @@ export default class CoreSitePreferencesPage implements AfterViewInit, OnDestroy
     handlers: CoreListItemsManager<CoreSettingsHandlerToDisplay, CoreSettingsHandlersSource>;
 
     dataSaver = false;
-    readonly limitedConnection = CoreNetwork.isCellularSignal();
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly limitedConnection = CoreNetwork.isCellularSignal;
+    readonly isOnline = CoreNetwork.onlineSignal;
 
     protected siteId: string;
     protected sitesObserver: CoreEventObserver;
diff --git a/src/core/features/settings/pages/synchronization/synchronization.ts b/src/core/features/settings/pages/synchronization/synchronization.ts
@@ -47,8 +47,8 @@ export default class CoreSettingsSynchronizationPage implements OnInit, OnDestro
 
     sitesLoaded = false;
     dataSaver = false;
-    readonly limitedConnection = CoreNetwork.isCellularSignal();
-    readonly isOnline = CoreNetwork.onlineSignal();
+    readonly limitedConnection = CoreNetwork.isCellularSignal;
+    readonly isOnline = CoreNetwork.onlineSignal;
 
     protected isDestroyed = false;
     protected sitesObserver: CoreEventObserver;
diff --git a/src/core/services/network.ts b/src/core/services/network.ts
@@ -52,6 +52,8 @@ export class CoreNetworkService extends Network {
     protected connectStableTimeout?: number;
     protected readonly online = signal(false);
     private readonly _connectionType = signal(CoreNetworkConnectionType.UNKNOWN);
+    protected readonly cellularSignal = computed<boolean>(() => this.connectionTypeSignal() === CoreNetworkConnectionType.CELL);
+    protected readonly wifiSignal = computed<boolean>(() => this.connectionTypeSignal() === CoreNetworkConnectionType.WIFI);
 
     constructor() {
         super();
@@ -236,7 +238,7 @@ export class CoreNetworkService extends Network {
      *
      * @returns Signal.
      */
-    onlineSignal(): Signal<boolean> {
+    get onlineSignal(): Signal<boolean> {
         return this.online.asReadonly();
     }
 
@@ -245,7 +247,7 @@ export class CoreNetworkService extends Network {
      *
      * @returns Signal.
      */
-    connectionTypeSignal(): Signal<CoreNetworkConnectionType> {
+    get connectionTypeSignal(): Signal<CoreNetworkConnectionType> {
         return this._connectionType.asReadonly();
     }
 
@@ -314,7 +316,7 @@ export class CoreNetworkService extends Network {
      * @returns Whether the device uses a wifi connection.
      */
     isWifi(): boolean {
-        return this.connectionType === CoreNetworkConnectionType.WIFI;
+        return this.wifiSignal();
     }
 
     /**
@@ -323,25 +325,25 @@ export class CoreNetworkService extends Network {
      * @returns Whether the device uses a limited connection.
      */
     isCellular(): boolean {
-        return this.connectionType === CoreNetworkConnectionType.CELL;
+        return this.cellularSignal();
     }
 
     /**
      * Returns a signal to watch if the device uses a cellular connection.
      *
      * @returns Signal.
      */
-    isCellularSignal(): Signal<boolean> {
-        return computed<boolean>(() => this.connectionTypeSignal()() === CoreNetworkConnectionType.CELL);
+    get isCellularSignal(): Signal<boolean> {
+        return this.cellularSignal;
     }
 
     /**
      * Returns a signal to watch if the device uses a wifi connection.
      *
      * @returns Signal.
      */
-    isWifiSignal(): Signal<boolean> {
-        return computed<boolean>(() => this.connectionTypeSignal()() === CoreNetworkConnectionType.WIFI);
+    get isWifiSignal(): Signal<boolean> {
+        return this.wifiSignal;
     }
 
 }
