Skip to content

Overlay improvements #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thibaultzanini wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Overlay improvements #1990

thibaultzanini wants to merge 15 commits into from

Conversation

@thibaultzanini
Copy link
Contributor

@thibaultzanini thibaultzanini commented Jul 5, 2018 •
edited
Loading

  • can specify the height and width of the overlay
  • can change the default behaviour when a user hit the escape key dismissOnEscape
  • can dismiss the overlay on scroll events dismissOnScroll
  • can specify the anchor position => 'left' | 'right' | 'bottom' | 'top'
  • Adapt the overlay position when it reaches the end of the browser boundaries
  • can attach an overlay to a control component to automatically show the overlay
  • Allow to be rendered within a container
  • add a toggle method
  • cleaning up
  • add overlay.info

screen capture on 2018-07-06 at 16-45-37

@thibaultzanini thibaultzanini self-assigned this Jul 5, 2018
@thibaultzanini thibaultzanini requested a review from marchant July 5, 2018 18:42
@hthetiot hthetiot mentioned this pull request Jan 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marchant marchant Awaiting requested review from marchant

Assignees

@thibaultzanini thibaultzanini

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thibaultzanini