Skip to content

Allows specifying reverter on text.reel #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnnykahalawai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allows specifying reverter on text.reel #1983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ui/text.reel/text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ var MontageText = exports.Text = Component.specialize( /** @lends module:montag
value: null
},

/**
* An optional reverter for transforming the `value` into the
* corresponding rendered text.
* Converters are called at time of draw.
* @type {?Converter}
* @default null
*/
reverter: {
value: null
},

/**
* The default string value assigned to the Text instance.
* @type {string}
Expand Down Expand Up @@ -91,7 +102,9 @@ var MontageText = exports.Text = Component.specialize( /** @lends module:montag
var displayValue = (typeof this._value !== "undefined" && this._value !== null) ? this._value : this.defaultValue;

//push to DOM
this._valueNode.data = this.converter ? this.converter.convert(displayValue) : displayValue;
this._valueNode.data = this.converter ? this.converter.convert(displayValue) :
this.reverter ? this.reverter.revert(displayValue) :
displayValue;
}
}

Expand Down