-
Notifications
You must be signed in to change notification settings - Fork 216
Adds an application.info #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marchant
wants to merge
2
commits into
montagejs:master
Choose a base branch
from
marchant:add-application.info
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds an application.info #1937
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "root": { | ||
| "object": "montage/core/application[application]", | ||
| "values": { | ||
| "loginPOSTURL": "https://someserver.domain.com/login" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
|
|
||
| <title>Application Sample</title> | ||
|
|
||
| <script src="../../../montage.js" async></script> | ||
| <script type="text/montage-serialization"> | ||
| { | ||
| "owner": { | ||
| "prototype": "montage/ui/loader.reel" | ||
| }, | ||
| "application": { | ||
| "object": "application.mjson" | ||
| } | ||
| } | ||
| </script> | ||
| </head> | ||
| <body> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "name": "application-sample", | ||
| "version": "0.1.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "montage": "*" | ||
| }, | ||
| "mappings": { | ||
| "montage": "../../../" | ||
| }, | ||
| "applicationPrototype":"test-application" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| var Application = require("montage/core/application").Application; | ||
|
|
||
| exports.TestApplication = Application.specialize(/** @lends Main# */ { | ||
| constructor: { | ||
| value: function Application() { | ||
| console.log("Custom TestApplication constructed"); | ||
| } | ||
| }, | ||
|
|
||
|
|
||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| html, body, .Main { | ||
| padding: 0; | ||
| margin: 0; | ||
| height: 100%; | ||
| width: 100%; | ||
| font-family: "Helvetica Neue Light", "Lucida Grande", "Calibri", "Arial", sans-serif; | ||
| } | ||
|
|
||
| .Main, .anchors { | ||
| display: flex; | ||
| align-items: center; | ||
| flex-direction: column; | ||
| flex: 1; | ||
| -webkit-font-smoothing: antialiased; | ||
| } | ||
|
|
||
| header { | ||
| margin-top: 20px; | ||
| font-size: 42px; | ||
| font-weight: bold; | ||
| color: #333; | ||
| } | ||
|
|
||
| .anchor { | ||
| text-decoration: none; | ||
| color: #555; | ||
| margin-top: 40px; | ||
| } | ||
|
|
||
| .anchor.montage--active { | ||
| color: #3a8fcf; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <link rel="stylesheet" type="text/css" href="main.css"> | ||
| <script type="text/montage-serialization"> | ||
| { | ||
| "owner": { | ||
| "values": { | ||
| "element": {"#": "main"} | ||
| } | ||
| }, | ||
| "application": { | ||
| }, | ||
| "hello": { | ||
| "prototype": "montage/ui/text.reel", | ||
| "values": { | ||
| "element": {"#": "hello"}, | ||
| "value": {"=":"@application.loginPOSTURL"} | ||
| } | ||
| } | ||
|
|
||
| } | ||
| </script> | ||
|
|
||
| </head> | ||
| <body> | ||
| <div data-montage-id="main" class="Main"> | ||
| <header>Application Sample</header> | ||
| <section class=""> | ||
|
|
||
| <span data-montage-id="hello"></span> | ||
| </section> | ||
| </div> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| var Component = require("montage/ui/component").Component; | ||
|
|
||
| exports.Main = Component.specialize(/** @lends Main# */ { | ||
|
|
||
|
|
||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"applicationPrototype":"test-application" in package id unknown property to me.
I would prefer in mjson "prototype": "test-application", is that possible?