Skip to content

Event distribution performance tweaks #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marchant wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Event distribution performance tweaks #1879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c45c9b2
adds property on instance to influence object shape
marchant Oct 9, 2017
ea9e348
Avoids creating an empty array that goes unused
marchant Oct 9, 2017
2969e85
Avoids creating an empty array that may not be used
marchant Oct 9, 2017
f8d05b4
Merge branch 'master' into event-distribution-performance-tweaks
hthetiot Dec 28, 2017
5659de7
Merge branch 'master' into event-distribution-performance-tweaks
hthetiot Dec 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions core/event/event-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1485,12 +1485,12 @@ var EventManager = exports.EventManager = Montage.specialize(/** @lends EventMan
methodNameForBubblePhaseOfEventType: {
enumerable: false,
value: function methodNameForBubblePhaseOfEventType(eventType, identifier, capitalizedEventType, capitalizedIdentifier) {
var eventTypeBucket;
var eventTypeBucket, eventTypeString = String(eventType);
if (identifier) {
eventTypeBucket = this._bubbleMethodNameByEventTypeIdentifier_.get(eventType) || (this._bubbleMethodNameByEventTypeIdentifier_.set(eventType, new Map())).get(eventType);
return eventTypeBucket.get(identifier) || (eventTypeBucket.set(identifier, ("handle" + (capitalizedIdentifier || identifier.toCapitalized()) + (capitalizedEventType || eventType.toCapitalized())))).get(identifier);
eventTypeBucket = this._bubbleMethodNameByEventTypeIdentifier_.get(eventTypeString) || (this._bubbleMethodNameByEventTypeIdentifier_.set(eventTypeString, new Map())).get(eventTypeString);
return eventTypeBucket.get(identifier) || (eventTypeBucket.set(identifier, ("handle" + (capitalizedIdentifier || identifier.toCapitalized()) + (capitalizedEventType || eventTypeString.toCapitalized())))).get(identifier);
} else {
return this._bubbleMethodNameByEventType_.get(eventType) || (this._bubbleMethodNameByEventType_.set(eventType, ("handle" + (capitalizedEventType || eventType.toCapitalized())))).get(eventType);
return this._bubbleMethodNameByEventType_.get(eventTypeString) || (this._bubbleMethodNameByEventType_.set(eventTypeString, ("handle" + (capitalizedEventType || eventTypeString.toCapitalized())))).get(eventTypeString);
}
}
},
Expand All @@ -1508,13 +1508,13 @@ var EventManager = exports.EventManager = Montage.specialize(/** @lends EventMan
methodNameForCapturePhaseOfEventType: {
enumerable: false,
value: function methodNameForCapturePhaseOfEventType(eventType, identifier, capitalizedEventType, capitalizedIdentifier) {
var eventTypeBucket;
var eventTypeBucket, eventTypeString = String(eventType);
if (identifier) {
eventTypeBucket = this._catptureMethodNameByEventTypeIdentifier_.get(eventType) || (this._catptureMethodNameByEventTypeIdentifier_.set(eventType,new Map())).get(eventType);
return eventTypeBucket.get(identifier) || (eventTypeBucket.set(identifier,("capture" + (capitalizedIdentifier || identifier.toCapitalized()) + (capitalizedEventType || eventType.toCapitalized())))).get(identifier);
eventTypeBucket = this._catptureMethodNameByEventTypeIdentifier_.get(eventTypeString) || (this._catptureMethodNameByEventTypeIdentifier_.set(eventTypeString,new Map())).get(eventTypeString);
return eventTypeBucket.get(identifier) || (eventTypeBucket.set(identifier,("capture" + (capitalizedIdentifier || identifier.toCapitalized()) + (capitalizedEventType || eventTypeString.toCapitalized())))).get(identifier);
} else {
return this._captureMethodNameByEventType_.get(eventType) ||
(this._captureMethodNameByEventType_.set(eventType, ("capture" + (capitalizedEventType || eventType.toCapitalized())))).get(eventType);
return this._captureMethodNameByEventType_.get(eventTypeString) ||
(this._captureMethodNameByEventType_.set(eventTypeString, ("capture" + (capitalizedEventType || eventTypeString.toCapitalized())))).get(eventTypeString);
}
}
},
Expand Down Expand Up @@ -2822,7 +2822,7 @@ var EventManager = exports.EventManager = Montage.specialize(/** @lends EventMan

var targetCandidate = target,
application = this.application,
eventPath = [],
eventPath,
discoveredTargets = this._eventPathForTargetMap;

discoveredTargets.clear();
Expand All @@ -2832,7 +2832,7 @@ var EventManager = exports.EventManager = Montage.specialize(/** @lends EventMan

do {
if (!discoveredTargets.has(targetCandidate)) {
eventPath.push(targetCandidate);
(eventPath || (eventPath = [])).push(targetCandidate);
discoveredTargets.set(targetCandidate,true);
}

Expand Down
6 changes: 6 additions & 0 deletions core/event/mutable-event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ if (typeof window !== "undefined") {
@class MutableEvent
*/
var MutableEvent = exports.MutableEvent = Montage.specialize(/** @lends MutableEvent# */ {
constructor: {
value: function() {
this._currentTarget = void 0;
return this;
}
},

/**
@private
Expand Down