Make sure cancelPrevious is a function before trying to call it.

[thibaultzanini]

No description provided.

[kriskowal]

Perhaps make this check earlier, and throw an error into the caller that provides it. cancelPrevious should be undefined or a function at this point.

[marchant]

Thanks Kris, wouldn't throwing risk slowing down code by being deoptimized?

On Sep 8, 2016, at 15:53, Kris Kowal [email protected] wrote:

Perhaps make this check earlier, and throw an error into the caller that provides it. cancelPrevious should be undefined or a function at this point.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[kriskowal]

V8 does not penalize throw, but it does penalize try/catch, and that
problem can be mitigated by only using try/catch in very small functions
that delegate all the real work. The try/catch does not penalize the entire
stack.

On Thu, Sep 8, 2016 at 5:20 PM Benoit Marchant [email protected]
wrote:

Thanks Kris, wouldn't throwing risk slowing down code by being deoptimized?

On Sep 8, 2016, at 15:53, Kris Kowal [email protected] wrote:

Perhaps make this check earlier, and throw an error into the caller that
provides it. cancelPrevious should be undefined or a function at this point.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#53 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADrhvQCCe8AvRa3Q2Q0zzrdH7BDDbcKks5qoKZAgaJpZM4J4iCY
.

[thibaultzanini]

PR updated

[hthetiot]

@thibaultzanini check Travis

[hthetiot]

@thibaultzanini could you rebase on master. Thx.