Skip to content

Treat null, undefined, and NaN as viral contaigons #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kriskowal wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Treat null, undefined, and NaN as viral contaigons #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion observers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ exports.makeDefinedObserver = makeDefinedObserver;
function makeDefinedObserver(observeValue) {
return function observeDefault(emit, scope) {
return observeValue(autoCancelPrevious(function replaceValue(value) {
return emit(value != null);
return emit(Operators.defined(value));
}), scope);
};
}
Expand Down
4 changes: 3 additions & 1 deletion operators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ exports.or = function (a, b) {
};

exports.defined = function (value) {
return value != null;
// value != null eliminates null and undefined
// value === value eliminates NaN
return value != null && value === value;
};

// "startsWith", "endsWith", and "contains" are overridden in
Expand Down