Improve the application and add options to download all rooms #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yblossier
commented
Dec 21, 2022
•
yblossier
commented
- Add colors in messages
- Add the option to set the room-id to wildcard (*) to dl all rooms
- Add the option to set the room-name to wildcard (*) to dl all rooms
- Adapt the code to auto-manage the room folder name in the output dir
- Improve the getRoomName() func to auto deduce the name in private chat
- Update Readme and Help
- Add colors in messages - Add the option to set the room-id to wildcard (*) to dl all rooms - Adapt the code to auto-manage the room folder name in the output dir - Improve the getRoomName func to auto deduce the name in private chat
- Rollback on missing code to use room-name - Add missing option of wildcard in room-name
Following the changes, update Readme and the help to describe the new options and usages
yblossier
changed the title
|
Hi @yblossier , First of all, thanks for the pull request. Nevertheless I'm a not a fan of pull requests that are to broad. I prefer pull request focused on one feature, it is easier to review. Is it possible for you to create several pull requests, one for each feature you want to be added (e.g one for the colored output, one for the wildcard stuff and one for the CI)? |
|
Hi @montag451, I understand but some of them can't be splitted because there are common changes especially for colored text). How I can split since I have commit the changes ? |
Sanitize the room name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.