add png chunk reader, expose more of codec and bitmap

[mgood7123]

No description provided.

[mattleibow]

Very nice PR. All this looks good. I do have some suggestions and also a couple of nitpicks.

Mainly some properties are just named differently or return a higher level object in C#, so either we can add a new property to do this Size => Info.Size or we can use the existing property.

Then the last nit is the underscores in the class names. My generator is not very smart. It often gets things wrong.

[mgood7123]

Very nice PR. All this looks good. I do have some suggestions and also a couple of nitpicks.

Mainly some properties are just named differently or return a higher level object in C#, so either we can add a new property to do this Size => Info.Size or we can use the existing property.

Then the last nit is the underscores in the class names. My generator is not very smart. It often gets things wrong.

alright :)

My generator is not very smart. It often gets things wrong.

haha :)

[mattleibow]

I think the find/replace may have been too powerful, so the google code needs to be reverted a bit.

Also, we need a enum mapping like this to protect against the Google Unnecessary Reorder ™️ that will take place when we update: https://github.com/mono/skia/blob/xamarin-mobile-bindings/src/c/sk_enums.cpp#L244-L246

[mgood7123]

I think the find/replace may have been too powerful, so the google code needs to be reverted a bit.

Also, we need a enum mapping like this to protect against the Google Unnecessary Reorder ™️ that will take place when we update: https://github.com/mono/skia/blob/xamarin-mobile-bindings/src/c/sk_enums.cpp#L244-L246

fixed for now :)

[mattleibow]

The only thing left is the enum added to sk_enums.cpp

[mgood7123]

The only thing left is the enum added to sk_enums.cpp

which one?

[mgood7123]

The only thing left is the enum added to sk_enums.cpp

like this?

// sk_codec_selection_policy_t
static_assert ((int)SkCodec::SelectionPolicy::kPreferStillImage   == (int)PREFER_STILL_IMAGE_SK_CODEC_SELECTION_POLICY,   ASSERT_MSG(SkCodec::SelectionPolicy, sk_codec_selection_policy_t));
static_assert ((int)SkCodec::SelectionPolicy::kPreferAnimation    == (int)PREFER_ANIMATION_SK_CODEC_SELECTION_POLICY,     ASSERT_MSG(SkCodec::SelectionPolicy, sk_codec_selection_policy_t));