-
Notifications
You must be signed in to change notification settings - Fork 596
Add comprehensive PR review agent for SkiaSharp #3411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: mattleibow <[email protected]>
|
@copilot i see the original had over 1000 lines, this is just over 500. This means that there is probably half the content missing. Please make sure you didn't skip anything. Make sure you covered the interop, the testing, the samples, the platforms, the docs and more. Look at the repo and see what parts are the and make sure the reviewer covers it. Also, we still need to keep the parts about running tests and iteration. Also, keep in mind that some changes will require native code, and this will require the correct native platform to be built before running tests. |
…lines and review processes Co-authored-by: mattleibow <[email protected]>
Expanded the PR reviewer from 578 to 1,428 lines (147% of MAUI's 1,125 lines). Added: Testing Guidelines (~400 lines):
Review Process (~350 lines):
Providing Feedback (~200 lines):
Coverage Verified: Commit: eb9b599 |
Description of Change
Adds a comprehensive, specialized PR review agent tailored to SkiaSharp's three-layer architecture (C++, C API, C#) and memory management requirements. Based on dotnet/maui's PR reviewer (1,125 lines) and significantly expanded to 1,428 lines (127% of original) with SkiaSharp-specific focus.
Key Features:
externals-download,libs,teststargets)AGENTS.md,design/memory-management.md, path-specific instruction filessk_ref_sp()usage, disposal patterns)IntPtrin public APIsComprehensive Coverage (1,428 lines):
Testing Guidelines (~400 lines):
Review Process (~350 lines):
Providing Feedback (~200 lines):
SkiaSharp-Specific Sections:
Complete Coverage:
The agent exceeds MAUI reviewer's thoroughness while maintaining SkiaSharp-specific focus on memory management, cross-layer consistency, and native interop. It provides step-by-step workflows with exact commands, code examples, and educational guidance for contributors.
Bugs Fixed
None.
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.