Implemented deleteImage API, state and tests #945

gabrieltmonkai · 2025-10-08T15:19:21Z

Overview

Jira Ticket Reference : MN-780

Added a new deleteImage function to handle image deletion of an inspection.

Checklist before requesting a review

I have updated the unit tests based on the changes I made
I have updated the docs (TSDoc / README / global doc) to reflect my changes
I have updated the local app configs if needed
I have performed self-QA of my feature by testing the apps and packages and made sure that :
- No regression or new bug has occurred
- The acceptance criteria listed in the ticket are met
- Self-QA was made on both desktop and mobile

packages/common/src/state/actions/deletedOneImage.ts

packages/network/README.md

packages/network/src/api/image/requests.ts

dlymonkai · 2025-10-20T16:57:43Z

packages/network/src/api/image/requests.ts

+  const formData = JSON.stringify({
+    authorized_tasks_statuses: [ProgressStatus.NOT_STARTED],
+  });
+  const kyOptions = getDefaultOptions(config);
+  kyOptions.headers = {
+    ...kyOptions.headers,
+    'Content-Type': 'application/json',
+  };
+  try {
+    const response = await ky.delete(`inspections/${options.id}/images/${options.imageId}`, {
+      ...kyOptions,
+      body: formData,
+    });


I don't think that you need this 'content-type', you can skip using it.
And use json property of ky function passing
{ authorized_tasks_statuses: [ProgressStatus.NOT_STARTED]}

Using the json property instead of body allowed me to get rid of content-type, otherwise the API would respond with 415 Code, saying "Did not attempt to load JSON data because the request Content-Type was not 'application/json'.".

Do you still have this error?

packages/common/src/state/actions/deletedOneImage.ts

dlymonkai · 2025-10-21T11:58:36Z

packages/network/README.md

+Delete an image from an inspection. The resulting action of this request will contain the details of the image that has
+been created in the API.


Change created text to deleted

dlymonkai · 2025-10-21T12:02:02Z

packages/network/test/api/image/requests.test.ts

+      await deleteImage(options, apiConfig, dispatch);
+
+      expect(getDefaultOptions).toHaveBeenCalledWith(apiConfig);
+      expect(ky.delete).toHaveBeenCalledWith(
+        `inspections/${options.id}/images/${options.imageId}`,
+        expect.objectContaining(getDefaultOptions(apiConfig)),
+      );
+      expect(dispatch).toHaveBeenCalledWith({
+        type: MonkActionType.DELETED_ONE_IMAGE,
+        payload: {
+          inspectionId: options.id,
+          imageId: undefined,


Mock the response of deleteImage and get the body.
Don't forget to change the expected imageId of dispatch function

dlymonkai · 2025-10-22T13:07:50Z

packages/network/test/api/image/requests.test.ts

+        },
+      });
+      expect(result).toEqual({
+        id: 'delete-test-fake-id',


Here it shouldn't be a hardcoded string, but body.id

dlymonkai · 2025-10-22T13:18:03Z

packages/network/test/api/image/requests.test.ts

+        type: MonkActionType.DELETED_ONE_IMAGE,
+        payload: {
+          inspectionId: options.id,
+          imageId: result.id,


Actually you want to get the real response of ky.delete, so instead of result.id. It should be body.id

dlymonkai · 2025-10-22T13:20:16Z

packages/network/test/api/image/requests.test.ts

+    });
+
+    it('should display an error if deletion fails', async () => {
+      const err = new Error('test delete error');


Could you change it to kebab-case convention please

Reset state objects containing the deleted image Updated objects to be deleted in State Updated API export and added more tests Added docs Updated Tests

gabrieltmonkai requested a review from dlymonkai October 8, 2025 15:19

dlymonkai reviewed Oct 9, 2025

View reviewed changes

packages/common/src/state/actions/deletedOneImage.ts Show resolved Hide resolved

gabrieltmonkai force-pushed the feat/MN-780/create-deleteImage-api branch from 3ab10ff to 4121c7f Compare October 9, 2025 14:14

dlymonkai reviewed Oct 9, 2025

View reviewed changes

packages/common/src/state/actions/deletedOneImage.ts Outdated Show resolved Hide resolved

gabrieltmonkai force-pushed the feat/MN-780/create-deleteImage-api branch 7 times, most recently from 0788148 to cf49a7c Compare October 16, 2025 10:42

gabrieltmonkai force-pushed the feat/MN-780/create-deleteImage-api branch from cf49a7c to e8c1f0d Compare October 20, 2025 08:59