Skip to content

impr(quotes): review French Quotes (@bersace) #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bersace
Copy link

@bersace bersace commented Mar 20, 2025

Description

Hi,

Thanks for monkeytype, its an awesome project and website.

Here is a clean of french quotes to avoid religion, politics, slang and other disruptive contents. The purpose of this patch is to keep quotes welcoming and avoid disrupt typing practice with unrelated topics. In a way, quotes should be boring.

Do you want de renumber ids ?

Regards,
Étienne

Checks

  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Mar 20, 2025
@bersace bersace changed the title impr(quotes): review French Quotes @bersace impr(quotes): review French Quotes (@bersace) Mar 20, 2025
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 20, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 20, 2025
@Miodec
Copy link
Member

Miodec commented Mar 25, 2025

Do you think you could add a few quotes to make up for all the quotes that had to be removed? Also, no need to change the IDs. For the new quotes just continue from the last ID.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants