fix: preserve non-object Antigravity configs - #265
Open
aikinley wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A valid JSON array passes the current syntax check, then the Python fallback calls
cfg.get(...)and exits underset -e. The same incompatible shape also breaks the jq assignment path. A healthy monk-agent therefore appears to fail solely because an existing Antigravity config has the wrong root type.Validation
C:\Program Files\Git\bin\bash.exe tests/start-monk-agent-antigravity-nonobject-config.shC:\Program Files\Git\bin\bash.exe -n scripts/start-monk-agent.shgit diff --checkThe regression fails on pristine v0.1.54 with
AttributeError: 'list' object has no attribute 'get'and passes with this change while preserving the original config.Generated artifacts
GENERATED.mdsays the public tree is generated from the privatemonk-agent/pluginsource. This PR updates the mirrored public artifacts consistently; the corresponding source change should be ported before the next regeneration.Fixes #255