fix: use basic parsing for Windows installer downloads - #259
Conversation
|
Revalidated this patch against the current main release v0.1.54 (2a4f9cf) on Windows PowerShell 5.1. Results: ensure_basic_parsing_status=pass downloads=2; PowerShell parser validation passed for 4/4 files; git diff --check upstream/main...HEAD passed. The branch is already based on v0.1.54, so no rebase or code changes are required. |
|
The Install E2E workflow for the latest commit is currently awaiting approval before any jobs can start (fork contribution). Could a maintainer approve the workflow run when convenient? The Windows PowerShell 5.1 regression passes locally with ensure_basic_parsing_status=pass downloads=2, and it is now wired into that workflow. |
a726fd8 to
789e809
Compare
|
Updated this branch onto the current v0.1.55 main release ( |
|
Closing as already fixed — Your diagnosis and your patch were both correct at the time of filing; that's recorded in triage. Nothing further needed here — thanks. |
Fixes #195.
What changed
-UseBasicParsingto bothInvoke-WebRequestcalls in the Windows bootstrap scriptInstall E2EGitHub Actions jobWhy
Windows PowerShell 5.1 can attempt to use the legacy Internet Explorer parser when
Invoke-WebRequestis called without-UseBasicParsing. On systems where IE is unavailable or its first-launch configuration is incomplete, bootstrap fails before the agent can be installed.Verification
powershell.exe -NoProfile -ExecutionPolicy Bypass -File tests/ensure-monk-agent-basic-parsing.ps1ensure_basic_parsing_status=pass downloads=2.github/workflows/install-e2e.ymlgit diff --checkpasses