fix: post-filter monk shell guard wrappers - #167
Open
renaissancefieldlite wants to merge 1 commit into
Open
Conversation
renaissancefieldlite
marked this pull request as ready for review
July 27, 2026 10:32
Author
|
Hi maintainers, quick bounty-status follow-up for accepted issues #133 and #140. Both issues are now closed as accepted and fixed in v0.1.52. PR #167 contains the related public wrapper regression coverage, although it now conflicts after the upstream release. Could you confirm whether scoring or rewards for #133 and #140 are recorded separately from this PR, and whether you need anything further from me? I will leave the conflicting PR unchanged unless you want it rebased or closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monk-agent hook block-monkallow/no-output results in the shell wrappers before allowing the command throughmonkddaemon invocations for Claude-format and Antigravity-format hooksgrep monk README.mdallowedplugins/monk/hooksand extend regression coverageRoot Cause
The wrappers trusted the helper completely whenever it exited successfully. If the installed helper returned no deny decision for wrapper forms such as
command monk deploy,bash -lc "monk deploy", absolute-pathmonk, ormonkd, the wrapper exited successfully and the shell command was allowed.Validation
sh -n hooks/block-monk.shsh -n plugins/monk/hooks/block-monk.shsh -n .antigravity-plugin/hooks/block-monk.shsh -n tests/block-monk-posix-postfilter.shsh tests/block-monk-posix-postfilter.shgit diff --checkNot run locally:
tests/block-monk-windows.ps1, because this machine does not have Windows PowerShell orpwshinstalled.Fixes #133.
Fixes #140.