Skip to content

Conversation

@tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Oct 20, 2025

Description

Summary of Changes

This PR rewrites the integration tests for node-specific/operation_examples.

Notes for Reviewers

I noticed that the entire file seems to be outdated, many tests are repeating test from other, more specific modules (such as aggregations, transactions, etc.), but at the same time I decided against refactoring the entire 4k lines file, focusing only on what's necessary to this project - getting rid of callbacks, and eventually mongodb-legacy wrapper.
Therefore changes contain just 1 test.

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review October 21, 2025 11:30
@tadjik1 tadjik1 requested a review from a team as a code owner October 21, 2025 11:30
@durran durran self-assigned this Oct 21, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 21, 2025
@durran durran merged commit 52267a5 into main Oct 21, 2025
25 of 27 checks passed
@durran durran deleted the NODE-7254 branch October 21, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants