Skip to content

Conversation

tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Oct 16, 2025

Description

Summary of Changes

This PR migrates the integration tests for integration/bson-options. The changes include:

  • Convert file in typescript
  • Refactor callbacks to async/await
  • Direct import from the src folder
Notes for Reviewers

To simplify the review process there is a separate commit for .js -> .ts conversion.
Then each file has it's own commit.

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review October 16, 2025 14:40
@tadjik1 tadjik1 requested a review from a team as a code owner October 16, 2025 14:40
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments

@baileympearson baileympearson self-assigned this Oct 16, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 16, 2025
@baileympearson baileympearson merged commit c39983d into main Oct 17, 2025
25 of 27 checks passed
@baileympearson baileympearson deleted the NODE-7203 branch October 17, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants