-
Couldn't load subscription status.
- Fork 1.8k
feat(NODE-5510)!: dont filter change stream options #4723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thanks for your work @durran! I have one minor question/suggestion in the code.
Co-authored-by: Sergey Zelenov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI check
Description
Allows unspecified options that are part of the $changeStream stage to be passed through to the server.
Summary of Changes
What is the motivation for this change?
NODE-5510
Release Highlight
Change Streams No Longer Whitelist $changeStream Stage Options
Uses are now able to pass any option to
collection.watch()and if it is invalid in the $changeStream stage of the pipeline the server will error. This is to allow users to provide newly added options quickly that are not in our public types.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript