Skip to content

Conversation

@durran
Copy link
Member

@durran durran commented Oct 10, 2025

Description

Allows unspecified options that are part of the $changeStream stage to be passed through to the server.

Summary of Changes

  • Changes the change stream options filter to be a blacklist instead of whitelist.

What is the motivation for this change?

NODE-5510

Release Highlight

Change Streams No Longer Whitelist $changeStream Stage Options

Uses are now able to pass any option to collection.watch() and if it is invalid in the $changeStream stage of the pipeline the server will error. This is to allow users to provide newly added options quickly that are not in our public types.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title feat(NODE-5510): dont filter change stream options feat(NODE-5510)!: dont filter change stream options Oct 20, 2025
@durran durran marked this pull request as ready for review October 20, 2025 06:36
@durran durran requested a review from a team as a code owner October 20, 2025 06:36
@tadjik1 tadjik1 self-assigned this Oct 20, 2025
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 20, 2025
Copy link
Member

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks for your work @durran! I have one minor question/suggestion in the code.

@tadjik1 tadjik1 added the Team Review Needs review from team label Oct 20, 2025
Co-authored-by: Sergey Zelenov <[email protected]>
@dariakp dariakp self-requested a review October 20, 2025 21:35
@dariakp dariakp removed the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 20, 2025
dariakp
dariakp previously approved these changes Oct 20, 2025
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI check

@dariakp dariakp merged commit a2daf76 into main Oct 21, 2025
25 of 27 checks passed
@dariakp dariakp deleted the NODE-5510 branch October 21, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants