Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGOID-5831 Remove usage of Rails private API #5908

Conversation

comandeo-mongo
Copy link
Contributor

No description provided.

Copy link
Contributor

@jamis jamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is it worth declaring __redefine as @api private? Or is the double underscore sufficient to indicate that?

@comandeo-mongo comandeo-mongo marked this pull request as ready for review December 3, 2024 10:17
@comandeo-mongo comandeo-mongo merged commit c2ae3fe into mongodb:master Dec 3, 2024
66 of 67 checks passed
@comandeo-mongo comandeo-mongo deleted the 5831-do-not-use-rails-private-api branch December 3, 2024 10:17
comandeo-mongo added a commit to comandeo-mongo/mongoid that referenced this pull request Dec 3, 2024
comandeo-mongo added a commit to comandeo-mongo/mongoid that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants