MONGOID-5818 Support Rails 8 #5876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo-mongo
force-pushed
the
5818-rails-8
branch
from
4f1e49c to
83a7e00
Compare
comandeo-mongo
force-pushed
the
5818-rails-8
branch
from
83a7e00 to
2aabbc2
Compare
jamis
approved these changes
Nov 7, 2024
| @@ -119,7 +123,7 @@ class << self | |||
| # an existing field. | |||
| # This condition also checks if the class has any descendants, because | |||
| # if it doesn't then it doesn't need a discriminator key. | |||
| return unless !fields.key?(discriminator_key) && !descendants.empty? | |||
| return if fields.key?(discriminator_key) || descendants.empty? | |||
There was a problem hiding this comment.
💪 Love to see De Morgan's laws in action :)
|
8.0 released if so :) |
Oh cool, glad that we unblocked Rails team for the GA release! 😂 |
comandeo-mongo
added a commit
to comandeo-mongo/mongoid
that referenced
this pull request
Nov 8, 2024
comandeo-mongo
added a commit
that referenced
this pull request
Nov 8, 2024
comandeo-mongo
added a commit
to comandeo-mongo/mongoid
that referenced
this pull request
Nov 11, 2024
comandeo-mongo
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.