Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGOID-5662 Deprecate Object#__to_inc__ and BigDecimal#__to_inc__ #5741

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jamis
Copy link
Contributor

@jamis jamis commented Nov 6, 2023

This extends @johnnyshields work in #5709 and deprecates Object#__to_inc__ and BigDecimal#__to_inc__.

Though these are implicitly private API methods, they were never explicitly declared as such, and so we're opting to deprecate them for now and remove them in a later major release.

@johnnyshields
Copy link
Contributor

johnnyshields commented Nov 7, 2023

Jamis, thanks for actioning these.

I'm happy to spend some time on the weekend updating my other PRs to preserve existing methods and deprecate them if it would help. Ah it looks like you're just doing this for the cases where it wasn't explicitly declared private or @api private...

@jamis
Copy link
Contributor Author

jamis commented Nov 7, 2023

@johnnyshields -- right. Dmitry and I discussed it and agree that unless a method was explicitly declared private or @api private, it must be implicitly public, and thus must be deprecated before being removed. It's annoying red tape, but we're preferring to be cautious.

MONGOID-5660 is my focus this week, and I'm optimistic about getting through them all by the end of the week. The groundwork you've laid for these is greatly appreciated!

@jamis jamis merged commit f99e917 into mongodb:master Nov 7, 2023
16 of 17 checks passed
@jamis jamis deleted the 5662-remove-to_inc branch November 7, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants