MONGOID-5579 Mongoid 8.1: Ruby, JRuby, Rails and MongoDB Server version support adjustments #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
johnnyshields
changed the title
johnnyshields
force-pushed
the
mongoid-8.1-compatibility-support
branch
2 times, most recently
from
14a669a to
2bf770c
Compare
johnnyshields
changed the title
johnnyshields
changed the title
- Notice of support for Ruby 3.2 and JRuby 9.4 - CI tests for Ruby 3.2 and JRuby 9.4 (Evergreen and Github) - Deprecation notice of MongoDB Server 3.6 and 4.0, Ruby 2.6, JRuby 9.3, Rails 5.2 - Deprecation of GeoNear class, index :background option, and Criteria#max_scan methods, all of which don't work on MongoDB Server 4.2+ - Backport mongodb#5470 which removes spec files re: Bignum and Fixnum - Workaround spec runner issue with JRuby related to "Logger::#{level}".constantize
johnnyshields
force-pushed
the
mongoid-8.1-compatibility-support
branch
from
2bf770c to
a1a669a
Compare
johnnyshields
force-pushed
the
mongoid-8.1-compatibility-support
branch
from
568074a to
d8292aa
Compare
johnnyshields
changed the title
|
@jamis this PR would be good to merge next, assuming the team agrees with the version changes here. |
|
ping, any progress on this? |
jamis
changed the title
|
TODO: This needs to be restacked as 8.2, since 8.1 was released without it. |
|
Closing as this is stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following to Mongoid 8.1:
/lib/code changes are required for these to work (PR MONGOID-5486 - Remove redundant spec files referencing Bignum and Fixnum #5470 affecting only specs is backported here.)Refer to #5567 for the removal of some of these deprecations in Mongoid 9.0
Notice that JRuby 9.4 is added and JRuby 9.3 is deprecated. I think it is reasonable for Mongoid 9 to support only JRuby 9.4 given the extra burden JRuby places on MongoDB drivers team.