CLOUDP-235689: Fix agent hostnames #579
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was breaking a lot of unit end e2e tests.
m1kola
added
the
skip-changelog
m1kola
commented
Nov 11, 2025
| podName := GetMultiPodName(stsName, clusterNum, podNum) | ||
| headlessService := GetMultiHeadlessServiceName(stsName, clusterNum) | ||
| return fmt.Sprintf("%s.%s.%s.svc.%s", podName, headlessService, namespace, domain) | ||
| return fmt.Sprintf("%s.%s.svc.%s", GetMultiServiceName(stsName, clusterNum, podNum), namespace, domain) |
Contributor
Author
There was a problem hiding this comment.
Reverting back to this (original, as seen in master) code fixes most of the tests, but breaks MongoDB-based multi-cluster.
Controller for MongoDBMultiCluster generates hostnames like this:
multi-replica-set-0-0-svc.mongodb-test.svc.cluster.local
multi-replica-set-1-0-svc.mongodb-test.svc.cluster.local
multi-replica-set-2-0-svc.mongodb-test.svc.cluster.local
But the controller for MongoDB multi-cluster replica sets creates hostnames like this even with the revert:
multi-replica-set-0-0.multi-replica-set-0-svc.mongodb-test.svc.cluster.local
multi-replica-set-1-0.multi-replica-set-1-svc.mongodb-test.svc.cluster.local
multi-replica-set-2-0.multi-replica-set-2-svc.mongodb-test.svc.cluster.local
Still trying to understand why.
m1kola
changed the title
m1kola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getReplicaSetMultiClusterMapfunction to make the linter happyGetMultiServiceFQDNback to it's original version as it was breaking a lot of unit and e2e tests.Proof of Work
CI must be greener. Still need to address more issues.
Checklist
skip-changeloglabel if not needed