CLOUDP-333181: Combined dockerfiles

[Julien-Ben]

Summary

Since we will stop re-building images daily, we won't have -context images anymore. We then don't need Dockerfiles templating.
This PR creates self-sufficient Dockerfiles that build our images without templating. They only need variables passed with ARG.
For images which already had a plain Dockerfile, it was renamed Dockerfile.old, and inventories modified accordingly.

For now, we keep templates and Sonar, until the Atomic Release epic is completed and we fully get rid of all of it.

Proof of Work

The proof of work will come when actually using them in a build pipeline. In a future PR.
This one is a noop, Dockerfiles are created but not used yet.

Methodology

The Dockerfiles were automatically generated, using Sonar templating, by adding special final_dockerfile tag to stages necessary to generate one. Using code like:

def test_build_init_database_dockerfile():  
    process_image(  
        image_name="init-database",  
        skip_tags=["release"],  
        include_tags=["final_dockerfile"],  
        build_args={  
            "registry": "localhost:5000",  
            "version": "1.1.0",  
            "is_appdb": False,  
            "mongodb_tools_url_ubi": "https://downloads.mongodb.org/tools/db/mongodb-database-tools-rhel93-x86_64-100.12.0.tgz",  
        },  
        build_options={},  
        inventory="inventories/init_database.yaml",  
    )  

Checklist

• Have you linked a jira ticket and/or is the ticket in the title?
• Have you checked whether your jira ticket required DOCSP changes?
• Have you checked for release_note changes?

[MaciejKaras]

I think this file is not used anywhere (this why I have removed it), but please double check.

[MaciejKaras]

same here, the LICENSE file was unused I think

[MaciejKaras]

b: same here

[MaciejKaras]

b: we should not change anything in inventories .yaml files. Those changes were introduced by me to be able to generate final Dockerfiles. After this they are not needed

[MaciejKaras]

file permission were changed so I can run the script manually, but this was a mistake. It should be reverted

[MaciejKaras]

This script should be removed and only added in the PR description as information how we generated the Dockerfiles

[Julien-Ben]

@MaciejKaras Should we keep this renaming ?

[MaciejKaras]

I would rather keep the same name here to prevent any changes. mongodb-kubernetes-init-appdb can unused for now

[Julien-Ben]

For review: Dockerfile.old files are the copy of the initial Dockerfile

[MaciejKaras]

lets keep this tag

[Julien-Ben]

I see that init_release_agents_on_ecr ran (and failed) on some commits, I'm confused why

[lucian-tosa]

Keep in mind that we should get rid of this image entirely CLOUDP-329374.
But we can merge it for now and make that change before 1.3

[viveksinghggits]

LGTM

[viveksinghggits]

nit: should we have these two go build commands in just one RUN statement? That would result into less layers and potentially smaller image.