Remove unused dependencies #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
requested changes
Sep 25, 2025
There was a problem hiding this comment.
Hi @FalkWoldmann, thanks for the PR! We use tokio-util in some of our docs examples, so the docs tests are failing. Can you please add that back in as a dev dependency? You can reproduce this by running cargo test --doc.
|
I re-introduced the dep, but now as a dev dependency |
There was a problem hiding this comment.
Sorry for the back-and-forth here: we pull in the tokio-util dependency to generate the docs as well, so tokio-util actually needs to be a non-dev dependency. Can you move it back to the dependencies list? I think we can omit the io feature while we're at it; we're only using compat in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.