RUST-1405 Expose full server response in Error
#1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
force-pushed
the
raw-result
branch
from
3d372dc to
e4a03f1
Compare
abr-egn
reviewed
Sep 26, 2025
| #[source] | ||
| pub(crate) source: Option<Box<Error>>, | ||
|
|
||
| pub(crate) server_response: Option<Box<Document>>, |
There was a problem hiding this comment.
I'd lean towards storing and exposing this as a RawDocumentBuf - this feels like a "lower level" API where the wire representation is more appropriate, and also it allows inspecting the bytes in case the server sends a response that doesn't fully parse.
| fn tracing_representation(&self) -> String { | ||
| self.to_string() | ||
| impl crate::error::Error { | ||
| fn tracing_representation(&self, max_document_length: usize) -> String { |
There was a problem hiding this comment.
Having to feature-conditionally thread this through everywhere is a bit unpleasant; what would you think about attaching max_document_length as a field of Error instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1405