GODRIVER-3035 Publish TopologyDescriptionChangedEvent on topology close. #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
qingyang-hu
force-pushed
the
godriver3035impl
branch
from
e5447da to
2e5069c
Compare
prestonvasquez
approved these changes
Apr 2, 2025
| @@ -488,7 +497,27 @@ func getNextTopologyDescriptionChangedEvent( | |||
| return nil, nil, errors.New("no topology description changed event published") | |||
| } | |||
|
|
|||
| return events[0], events[:1], nil | |||
| return events[0], events[1:], nil | |||
There was a problem hiding this comment.
Were these tests not running correctly? Do you know why this wasn't causing an error?
There was a problem hiding this comment.
We didn't have multiple events previously.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3035
Summary
Publish TopologyDescriptionChangedEvent on topology close.
Stacked on the top of #1964
Also updated spec tests for GODRIVER-2967
Background & Motivation