GODRIVER-3445 Move all logic for skipping spec tests by description into one place.

[matthewdale]

GODRIVER-3445

Summary

• Move all logic for skipping spec tests by description into a new function spectest.CheckSkip.
  • Note that many legacy spec tests are still skipped using a modified "skipReason" field in the spec test. We will address those in a separate PR.
• All spec tests should include the full JSON test filename in the test name.
• Fix a test name bug in TestAuthSpec introduced by GODRIVER-3175 Add Kubernetes support for OIDC. #1976

Background & Motivation

There are multiple blocks that are responsible for skipping spec tests based on description, but the logic is always the same. Unifying the logic in one place makes it easier to maintain the list of skipped tests and add new skipped tests when necessary.

The reason we should do this now is to facilitate skipping the tests to unblock #1932

Part of a stack of changes that must be reviewed in order:

1. GODRIVER-3445 Move all logic for skipping spec tests by description into one place. #1985 (this PR)
2. GODRIVER-3098 Sync SDAM spec tests at 348d2f39. #1986
3. GODRIVER-3098 Drop support for MongoDB 3.6 #1988

[mongodb-drivers-pr-bot]

API Change Report

No changes found!

[Copilot]

Pull Request Overview

This PR centralizes the logic for skipping spec tests by introducing a new function, spectest.CheckSkip, and updates several test files to leverage this shared functionality. Key changes include:

• Adding the unified spectest.CheckSkip function with a consolidated list of tests to be skipped.
• Refactoring legacy skipping logic in spec test files such as auth_spec_test.go and connstring_spec_test.go.
• Removing filename trimming and legacy skip mappings in integration, server selector, SDAM, BSON corpus, and topology tests so that full JSON filenames are retained.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/spectest/skip.go	Introduces the centralized skip logic using a map of test names to skip reasons.
x/mongo/driver/auth/auth_spec_test.go	Removes legacy skip logic in favor of spectest.CheckSkip and fixes a test naming issue.
x/mongo/driver/connstring/connstring_spec_test.go	Updates loop variable capturing and removes outdated filename trimming logic.
internal/integration/unified/unified_spec_runner.go	Replaces legacy skip mapping with calls to spectest.CheckSkip in test runners.
internal/integration/unified_spec_test.go	Similar updates to use spectest.CheckSkip alongside removal of outdated skip descriptions.
internal/serverselector/server_selector_test.go	Removes filename trimming logic in favor of including full test filenames.
x/mongo/driver/topology/sdam_spec_test.go	Refactors test name formatting by removing outdated filename adjustments.
bson/bson_corpus_spec_test.go	Adjusts test name and renames Test_BsonCorpus to TestBSONCorpus; removes filename trimming logic.
x/mongo/driver/topology/server_rtt_test.go	Updates test naming to use the full filename rather than trimming the ".json" extension.

[qingyang-hu]

Is "Network error on minPoolSize background creation" replaced?

[matthewdale]

That test was converted to a unified spec test in #1522 and now passes reliably (see here). Since the new unified test passes, I decided to not skip it.