Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2975 Fully support "errors.Is" and "errors.As" in BSON APIs. #1984

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

qingyang-hu
Copy link
Collaborator

@qingyang-hu qingyang-hu commented Mar 10, 2025

GODRIVER-2975

Summary

This PR draft is not meant to be merged. Read the comments of #1969 for details.
This PR and #1969 replace error assertions (except those in replaceErrors() in "mongo\errors.go") with errors.Is() and errors.As().

Background & Motivation

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Mar 10, 2025
Copy link
Contributor

API Change Report

No changes found!

@qingyang-hu qingyang-hu marked this pull request as ready for review March 11, 2025 21:08
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@qingyang-hu qingyang-hu merged commit c813005 into mongodb:master Mar 18, 2025
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants