GODRIVER-3140 Update client-side-encryption spec tests.#1651
Closed
qingyang-hu wants to merge 13 commits intomongodb:masterfrom
Closed
GODRIVER-3140 Update client-side-encryption spec tests.#1651qingyang-hu wants to merge 13 commits intomongodb:masterfrom
qingyang-hu wants to merge 13 commits intomongodb:masterfrom
Conversation
mongodb-drivers-pr-bot
Bot
added
the
review-priority-low
Contributor
API Change ReportNo changes found! |
qingyang-hu
force-pushed
the
godriver3140
branch
3 times, most recently
from
475502f to
96298c3
Compare
prestonvasquez
requested changes
Jun 10, 2024
| return nil | ||
| } | ||
| } | ||
| return fmt.Errorf("BSON type mismatch for key %s; expected %s, got %s", key, array.String(), actual) |
Member
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("BSON type mismatch for key %s; expected %s, got %s", key, array.String(), actual) | |
| return fmt.Errorf("BSON type mismatch for key %q; expected %s, got %q", key, array, actual.Type) |
%s will use the bson.RawValue.String() method for array. Additionally, suggest using the actual type rather than the value of actual in the error message.
| } | ||
| return fmt.Errorf("BSON type mismatch for key %s; expected %s, got %s", key, array.String(), actual) | ||
| default: | ||
| return fmt.Errorf("unsupported $$type: %s", t.String()) |
Member
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("unsupported $$type: %s", t.String()) | |
| return fmt.Errorf("unsupported $$type: %q", t) |
q will use the bsontype String() method.
| // $$type represents a type assertion | ||
| // for example {field: {$$type: "binData"}} should assert that "field" is an element with a binary value | ||
| return checkValueType(mt, key, actual.Type, typeVal.StringValue()) | ||
| switch t := typeVal.Type; t { |
Member
There was a problem hiding this comment.
Optional. Use a different name for this variable, such as typ.
prestonvasquez
previously approved these changes
Jun 11, 2024
matthewdale
reviewed
Jun 15, 2024
Comment on lines
+589
to
+591
| if t.clientOpts != nil && t.clientOpts.AutoEncryptionOptions != nil && len(t.failPointNames) > 0 { | ||
| t.Logf("configureFailPoint is not supported for auto encryption, skipping ClearFailPoints()") | ||
| t.failPointNames = t.failPointNames[:0] |
Contributor
There was a problem hiding this comment.
The added spec tests include both AutoEncryptionOptions and "configureFailPoint", which seems to suggest that "configureFailPoint" is being run successfully during the test (to enable the failpoint). Does disabling failpoints behave differently than enabling failpoints when AutoEncryptionOptions are set?
Contributor
Author
There was a problem hiding this comment.
Yes, clearing fail point fails for "mongocrypt error 1: command not supported for auto encryption: configureFailPoint".
^ The issue was caused because of GODRIVER-2123.
qingyang-hu
force-pushed
the
godriver3140
branch
8 times, most recently
from
9263a71 to
3ddf46a
Compare
qingyang-hu
force-pushed
the
godriver3140
branch
2 times, most recently
from
a859b1e to
80e941f
Compare
qingyang-hu
force-pushed
the
godriver3140
branch
from
c4c67dd to
928555a
Compare
qingyang-hu
force-pushed
the
godriver3140
branch
from
91f87f3 to
4dcc585
Compare
qingyang-hu
force-pushed
the
godriver3140
branch
2 times, most recently
from
17c4846 to
12fb07c
Compare
qingyang-hu
force-pushed
the
godriver3140
branch
2 times, most recently
from
ba5b63f to
b388b98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-3140
Summary
Update client-side-encryption spec tests, reflecting spec PR #1564.