[LG-5532] feat(time-input): Segment state utils #3385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from specified time zones
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces utility functions for managing time input segment state, including validation, formatting, and conversion between 12-hour and 24-hour formats. The implementation handles timezone conversions, segment validation, and provides comprehensive test coverage for UTC date creation from time segments.
- Adds utilities for validating and formatting time segments (hour, minute, second)
- Implements conversion logic between 12-hour and 24-hour time formats
- Introduces timezone-aware UTC date creation from time segments
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/time-input/src/utils/shouldSetValue/shouldSetValue.ts |
Core logic determining when to update time input value based on segment state |
packages/time-input/src/utils/isSameUTCDayAndTime/isSameUTCDayAndTime.ts |
Utility for comparing two dates for equality in UTC |
packages/time-input/src/utils/isEverySegmentValueExplicit/isEverySegmentValueExplicit.ts |
Validates that all time segments have unambiguous values |
packages/time-input/src/utils/isEverySegmentValid/isEverySegmentValid.ts |
Checks if all time segments are within valid ranges |
packages/time-input/src/utils/isEverySegmentFilled/isEverySegmentFilled.ts |
Verifies that all time segments contain values |
packages/time-input/src/utils/getNewUTCDateFromSegments/getNewUTCDateFromSegments.ts |
Creates UTC date from time segments with timezone support |
packages/time-input/src/utils/getFormattedTimeSegmentsFromDate/getFormattedTimeSegmentsFromDate.ts |
Extracts and formats time segments from a date object |
packages/time-input/src/utils/getFormattedTimeSegments/getFormattedTimeSegments.ts |
Pads time segments to 2-digit format |
packages/time-input/src/utils/findUnitOptionByDayPeriod/findUnitOptionByDayPeriod.ts |
Locates the AM/PM unit option matching a day period |
packages/time-input/src/utils/doesSomeSegmentExist/doesSomeSegmentExist.ts |
Checks if any time segment has a value |
packages/time-input/src/utils/convert12hTo24h/convert12hTo24h.ts |
Converts 12-hour format to 24-hour format |
packages/date-utils/src/newUTCFromTimeZone/newUTCFromTimeZone.ts |
Creates UTC date from local time in specified timezone |
packages/time-input/src/utils/index.ts |
Exports all new time input utility functions |
packages/date-utils/src/index.ts |
Exports new UTC timezone conversion utility |
| Test files (*.spec.ts) | Comprehensive test coverage for all new utilities |
| ); | ||
| }); | ||
|
|
||
| test('returns false is all segments are empty', () => { |
There was a problem hiding this comment.
Corrected spelling of 'is' to 'if' in test description.
Suggested change
| test('returns false is all segments are empty', () => { | |
| test('returns false if all segments are empty', () => { |
| ); | ||
| }); | ||
|
|
||
| test('returns true if at all segments are filled', () => { |
There was a problem hiding this comment.
The phrase 'at all segments' should be 'all segments' to be grammatically correct.
Suggested change
| test('returns true if at all segments are filled', () => { | |
| test('returns true if all segments are filled', () => { |
This was referenced Dec 15, 2025
Contributor
|
Size Change: +173 B (+0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
shaneeza
requested review from
TheSonOfThomp and
stephl3
and removed request for
a team
…orrect input validation
Contributor
|
Coverage after merging LG-5532/segments-state-utils into LG-5532/segments-display-values will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
This PR introduces utility functions for managing time input segment state, including validation, formatting, and conversion between 12-hour and 24-hour formats. The implementation handles timezone conversions, segment validation, and provides comprehensive test coverage.
This PR is the third PR in a chain of PRs
🧪 How to test changes