[LG-5766] fix: Icon fill support #3377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b7843ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +134 B (+0.01%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
adamrasheed
requested review from
TheSonOfThomp,
Copilot and
tsck
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes icon fill support by explicitly passing the fill prop through the createIconComponent function to the underlying SVG components. The change ensures that the fill prop (which is converted to a CSS color property by the generated icon components) is properly threaded through the icon wrapper.
Key changes:
- Modified
createIconComponentto explicitly destructure and pass thefillprop to SVG components - Added test coverage to verify that the
fillprop correctly applies CSS color styling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/icon/src/createIconComponent.tsx | Explicitly destructures fill from props and passes it to the SVG component |
| packages/icon/src/Icon.spec.tsx | Adds test to verify fill prop applies CSS color correctly |
Contributor
|
Coverage after merging ar/LG-5766-icon-fix into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Fixes a bug where the
fillprop was not being passed to the underlying SVG component when using icons created throughcreateIconComponent. Previously, thefillprop was being absorbed by the spread operator but not explicitly passed to theSVGComponent, causing the fill color to not apply correctly.🎟️ Jira ticket: LG-5766
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
Iconcomponent and render it with afillprop:<Icon glyph="Edit" fill="red" />pnpm test --filter=@leafygreen-ui/iconto confirm the fixIcon->Customstory in Storybook